✨ Fix Tilt by adding certManager option to the tilt.yaml chart #2233
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The tls flags are required if metrics-bind-address is set. Adding the certManager option to the tilt.yaml chart makes Tilt work again. Also fixed a couple spelling errors.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2233 +/- ##
==========================================
- Coverage 72.16% 71.84% -0.33%
==========================================
Files 85 86 +1
Lines 8440 8474 +34
==========================================
- Hits 6091 6088 -3
- Misses 1948 1984 +36
- Partials 401 402 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file you linked is the most basic set of values we use to deploy v1, on top of which we would set values to change deployment environment, for instance upstream and downstream, the latter of which has certmanager disabled. When we install v1 through upstream make targets, certmanager is enabled because all of the deployment variations use the |
|
/lgtm |
Exactly, helm allows us to combine multiple files together to create different manifests. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Interesting, we used to have a tilt CI, but it seems to have disappeared? |
|
Hmmm... it didn't run in this PR, but it does run (and pass) in others (#2213) |
openshift-merge-bot
bot
merged commit 6332ae3
into
operator-framework:main
|
Looks like it ran on PR creation, but not on merge? |
4 participants
Description
When the move was made to use helm charts for the Tilt configuration, the TLS components were not added. This means in the current state, both operator-controller and catalogd will exit on launch due to metrics-bind-address requiring the tls-key and tls-cert. This PR adds the certManager option to fix this issue.
Reviewer Checklist